Feat/UI checkbox component #2191
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
🦋 Changeset detectedLatest commit: 2387874 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
r-mulder
force-pushed
the
feat/ui-checkbox-component
branch
from
1cbd579
to
41c225a
Compare
.changeset/shaggy-files-juggle.md
Outdated
| "@kadena/react-ui": patch | ||
| --- | ||
|
|
||
| feat: new checkbox component added to the component library |
There was a problem hiding this comment.
Would recommend reading the CONTRIBUTING.md file in the root of kadena.js
Here's a snippet about changesets:
To keep everything clear for ourselves and our end users, we have a "changelog
etiquette". Only include changes that affect the consumer of your
package/app/product. It's not a commit log. Write descriptions that are
understandable from the consumers' perspective:
- Start descriptions with action verbs like "Add", "Remove", "Deprecate", "Fix",
"Improve", "Update".
- Avoid the term "bug", use "issue" instead.
- Add GitHub issue numbers when fixing those.
- When referring to public API changes, use backticks and parentheses for code
like function names and classes (e.g. `createClient()`,
`new TransactionBuilder()`, `hash`).
- Upgrades should be documented with old and new version numbers.
- Avoid trailing periods (unless in a description below the commit title).
Examples:
- Deprecate the `doSomething()` API function.
- Use `doSomethingBetter()` instead.
- Fix issue where `ExampleWidget` API did not handle dates correctly (fix #81)
- Improve the diagnostic logging when running in advanced mode.
- Upgrade from `react@15` to `react@16-beta` release of the flexible panels
feature
(Credits: [rushjs.io/pages/best_practices/change_logs][8])
If you don't see a need for authoring changelogs for your package (e.g. a PoC or
packages without consumers), add it to [.changeset/config.json#ignore][9].
There was a problem hiding this comment.
Clear, I'll edit this message. Thanks!
| alignItems: 'flex-start', | ||
| lineHeight: token('size.n4'), | ||
| cursor: 'pointer', |
There was a problem hiding this comment.
can alignItems and cursor be in atoms?
There was a problem hiding this comment.
Just discussed to remove atoms from the react-ui library. So this will change but I'll be moving the styles out the atoms function.
| }, | ||
| }; | ||
|
|
||
| export const _ReadOnlyChecked: CheckboxStoryType = { |
There was a problem hiding this comment.
curious: what's the reason for the underscore?
There was a problem hiding this comment.
One of the very few things I copy pasted.. I'll see if I can remove them
| @@ -68,7 +68,6 @@ type LinkStory = StoryObj<ILinkProps>; | |||
| export const _Button: LinkStory = { | |||
| args: { | |||
| children: 'Hello world', | |||
| variant: 'primary', | |||
There was a problem hiding this comment.
i believe the variant arg type defined in meta is incorrect. I think there should be color and style variant?
There was a problem hiding this comment.
Link and Button have the same API, except for the default value of the variant prop. So by removing this prop you get the "transparent" variant.
There was a problem hiding this comment.
ahh I see the variant includes styles and colors. thanks!
r-mulder
force-pushed
the
feat/ui-checkbox-component
branch
from
73031f4
to
2387874
Compare
This PR will add the new checkbox component to the library.
The checkbox is fully based on react aria with our custom styles.