-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix reorganization #136
Merged
Merged
Nix reorganization #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are some steps to verify that the various The default build(strips the debug symbols, is threaded and has no profiling)
The stripped executable size is 16.8MB:
--arg dontStrip true
Unstripped size is 24.6 MB:
--arg threaded false
Can't be run threaded:
--arg enableProfiling true
|
emmanueldenloye
approved these changes
Feb 23, 2023
jwiegley
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever stuff!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns our Nix configuration somewhat inside out and moves all the heavy lifting to
default.nix
fromflake.nix
.The rationale is that Nix flakes are inflexible by design so that they provide static information about their inputs and their outputs. By moving the interesting logic back to
default.nix
and importing it fromflake.nix
we're able to accept arguments to thenix-build
call to build our artifacts with parameters.This PR introduces the
dontStrip
,threaded
andenableProfiling
parameters todefault.nix
.In order to expose this new flexibility to our
chanweb-data-docker
images, this PR also inlinesdocker-legacy.nix
intodefault.nix
so that, say,nix-build --arg enableProfiling true -A dockerImage
builds a docker image with a CW-D binary built with profiling.Note that this
default.nix
still piggy backs on the new nix flakes feature for managing its inputs likehaskell.nix
andnixpkgs
.