Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all p2p endpoint requests with service endpoint requests avoiding the need to have a p2p configuration. This simplifies
chainweb-data
's command line interface, but more importantly, it avoids depending on CW-N's p2p endpoint, which is supposed to be for peer to peer communication only and is subject to backwards-incompatible changes.In particular, this PR moves the following requests to the service endpoint:
GET <node-endpoint>/chainweb/0.0/<network-id>/cut
GET <node-endpoint>/chainweb/0.0/<network-id>/chain/<chain-id>/payload/<block-hash>/outputs