Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid p2p dependency #160

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Avoid p2p dependency #160

merged 6 commits into from
Aug 14, 2023

Conversation

enobayram
Copy link
Contributor

@enobayram enobayram commented Aug 10, 2023

This PR replaces all p2p endpoint requests with service endpoint requests avoiding the need to have a p2p configuration. This simplifies chainweb-data's command line interface, but more importantly, it avoids depending on CW-N's p2p endpoint, which is supposed to be for peer to peer communication only and is subject to backwards-incompatible changes.

In particular, this PR moves the following requests to the service endpoint:

@enobayram enobayram self-assigned this Aug 10, 2023
This commit allows us to run a fill operation against a fast-development
node, facilitating the testing for this PR
@enobayram
Copy link
Contributor Author

I have tested this PR by running a chainweb-data instance from it against a mainnet01 and a fast-development node. It works without any issues in server and fill modes.

@enobayram enobayram changed the title Avoid p2p dependency [WIP] Avoid p2p dependency Aug 11, 2023
@enobayram
Copy link
Contributor Author

In addition to testing this PR on mainnet01 and fast-development, I've also double-checked that the cut and payload/outputs endpoints affected by this PR are unconditionally served on the Service API, see:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants