-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding accounts transfer history query endpoint v2 #76
Conversation
…nuel/account-history
worker function for writing rows to transfers table
It is ok if there are only three values in this field (given the other conditions of course)
this is necessary because the actual query takes some non-trivial amount of time to execute and we need this map during backfills, listens, etc. These are processes which should not be unnecessarily sluggish.
there is a build error. I need to figure out how to make a function with this type "PrimaryKey BlockT Identity -> Text". using unDbHash and coerce doesn't seem to work.
we need this in case there are gaps in the new upcoming transfers table
filling an empty table
…nuel/account-history
Here's what remains here:
|
amount type :: Double -> Scientific
…nuel/account-history
* update chainweb-api types * Change numeric type of transfer amount type to Decimal * move back to using Scientific * specify correct HasColumnType instance for KDAScientific
…nuel/account-history
In this instance, I want to be able to run a migration that doesn't give any warnings about user made edits to the chainweb-data db schema.
Here is a script to verify that the transfers table is filled correctly under all circumstances https://gist.github.com/emmanueldenloye/b814a07531afd06b9c6547bc66c5d902 Here is some command-line output showing that the accounts endpoint produces correct output https://gist.github.com/emmanueldenloye/cc7f6b14fa92606585f41ae71af45d46 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work on this PR, glad it's finally getting merged.
No description provided.