Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding accounts transfer history query endpoint v2 #76

Merged
merged 91 commits into from
Nov 24, 2022

Conversation

emmanueldenloye
Copy link
Contributor

No description provided.

worker function for writing rows to transfers table
It is ok if there are only three values in this field (given the other
conditions of course)
this is necessary because the actual query takes some non-trivial amount
of time to execute and we need this map during backfills, listens, etc.
These are processes which should not be unnecessarily sluggish.
there is a build error. I need to figure out how to make a function with
this type "PrimaryKey BlockT Identity -> Text". using unDbHash and
coerce doesn't seem to work.
we need this in case there are gaps in the new upcoming transfers table
filling an empty table
cabal.project Outdated Show resolved Hide resolved
exec/Chainweb/Listen.hs Outdated Show resolved Hide resolved
exec/Chainweb/Lookups.hs Outdated Show resolved Hide resolved
exec/Chainweb/Lookups.hs Outdated Show resolved Hide resolved
lib/ChainwebDb/Types/Common.hs Show resolved Hide resolved
exec/Chainweb/Worker.hs Show resolved Hide resolved
exec/Chainweb/FillTransfers.hs Outdated Show resolved Hide resolved
exec/Chainweb/FillTransfers.hs Outdated Show resolved Hide resolved
lib/ChainwebDb/Types/Transfer.hs Outdated Show resolved Hide resolved
exec/Chainweb/FillTransfers.hs Outdated Show resolved Hide resolved
@enobayram
Copy link
Contributor

enobayram commented Sep 6, 2022

Here's what remains here:

@emmanueldenloye
Copy link
Contributor Author

Here is a script to verify that the transfers table is filled correctly under all circumstances https://gist.github.com/emmanueldenloye/b814a07531afd06b9c6547bc66c5d902

Here is some command-line output showing that the accounts endpoint produces correct output https://gist.github.com/emmanueldenloye/cc7f6b14fa92606585f41ae71af45d46

Copy link
Contributor

@enobayram enobayram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work on this PR, glad it's finally getting merged.

@emmanueldenloye emmanueldenloye merged commit f0322dc into master Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants