Benchmark coin contract #322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilypi
approved these changes
Jul 31, 2019
| @@ -456,6 +461,9 @@ initCapabilities :: [Capability] -> EvalState | |||
| initCapabilities cs = set (evalCapabilities . capGranted) cs def | |||
| {-# INLINABLE initCapabilities #-} | |||
|
|
|||
| initModules :: ModuleCache -> EvalState -> EvalState | |||
| initModules mcache = set (evalRefs . rsLoadedModules) mcache | |||
|
|
|||
There was a problem hiding this comment.
You can INLINABLE this call, as well. There's no harm in inlining this as a pure function
There was a problem hiding this comment.
We're pretty close to having nice benchmarks for these functions so I'd probably wait in order to avoid knee-jerk inlining ...
|
|
||
| ``` | ||
| benchmarking pact-backend/coin-cp/transfer | ||
| time 97.43 μs (97.25 μs .. 97.68 μs) |
There was a problem hiding this comment.
That's a very significant speedup. Caching is important!
fosskers
added
the
component: contract-data
|
Closing for mainnet release, reopen later if still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.