Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ledger.rotate #85

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Remove ledger.rotate #85

merged 3 commits into from
Jun 23, 2023

Conversation

ggobugi27
Copy link
Collaborator

@ggobugi27 ggobugi27 commented Jun 14, 2023 •
edited

To comply with KIP-0019 account standards, ledger.rotate function is removed

jermaine150
jermaine150 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@jermaine150 jermaine150 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some merge conflicts, other then that, approved.

@ggobugi27 ggobugi27 closed this Jun 23, 2023
@ggobugi27 ggobugi27 reopened this Jun 23, 2023
@ggobugi27 ggobugi27 merged commit cad098c into v2 Jun 23, 2023
2 checks passed
@ggobugi27 ggobugi27 deleted the v2-remove-rotate branch June 23, 2023 17:00
ggobugi27 added a commit that referenced this pull request Jul 28, 2023
@ggobugi27
Remove ledger.rotate (#85)
a03ec6a 
* remove rotate

* fix wrong merge

---------

Co-authored-by: ggobugi27 <ggobugi27@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jermaine150 jermaine150 jermaine150 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ggobugi27 @jermaine150