Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Division before multiplication vulnerability added. #77

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

0xSandyy
Copy link
Contributor

@0xSandyy 0xSandyy commented Jun 6, 2024

Related Issue

Checklist

Describe the changes you've made:

This contribution adds a vulnerability that exploits solidity integer division which causes fractional loss due to truncation. I think we can create a new category called Solidity Math Issues which includes all the issues involving solidity math like divide by zero, rounding errors, rounding to 0, loss of precision, solidity truncation, etc in a single listing.

Type of change

Select the appropriate checkbox:

  • Bug fix (fixing an issue with existing vulnerability data)
  • New feature (adding a new vulnerability or category)
  • Documentation update (improving existing information)

Additional Information

I think the example I presented here is not formatted properly. Let me hear your recommendations and I will make changes accordingly.

@0xSandyy
Copy link
Contributor Author

0xSandyy commented Jun 6, 2024

Hi, the issue is listed in the dde3b88 commit. I will make sure to add more clear commit messages in the upcoming commits.

@kadenzipfel
Copy link
Owner

Should update this according to the discussion here: #70 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Divide before multiply
2 participants