Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with manual subscription #146

Closed
mquandalle opened this issue Oct 29, 2015 · 5 comments
Closed

Error with manual subscription #146

mquandalle opened this issue Oct 29, 2015 · 5 comments

Comments

@mquandalle
Copy link
Contributor

Hi @arunoda,

Fast-render produces some errors if the publication uses the DDP low level API, ie this.ready(). Here is a code example:

Meteor.publish('test', function() {
  this.ready();
});

FastRender.onAllRoutes(function() {
  this.subscribe('test');
});

This produces the following in the console:

W20151030-00:26:22.562(1)? (STDERR) Publish handler for null sent no ready signal
W20151030-00:26:25.288(1)? (STDERR) Publish handler for null sent no ready signal

If there were some data on the publication it would be correctly transmitted by fast-render, the issue is only the error in the logs.

@mquandalle
Copy link
Contributor Author

Hum it seems that something more subtle is going on...

Here is a clonable reproduction in case anyone care: https://github.com/wekan/wekan/tree/fast-render, the issue is with the board publication.

@arunoda
Copy link
Contributor

arunoda commented Oct 30, 2015

Just by looking at this, it seems like a issue with a null publication. I
will try to reproduce.
On 2015 ඔක් 30, සිකු at පෙ.ව. 5.10 Maxime Quandalle <
notifications@github.com> wrote:

Hum it seems something more subtle is going on...

Here is a clonable reproduction in case anyone care:
https://github.com/wekan/wekan/tree/fast-render


Reply to this email directly or view it on GitHub
#146 (comment)
.

@mquandalle
Copy link
Contributor Author

This is probably a side effect of a third-party package, 3stack:presence as I was able to demonstrate in this minimal clonable reproduction: https://github.com/mquandalle/meteor-fast-render-issue-146

@mquandalle
Copy link
Contributor Author

Ok actually that was easy, this package has a null publication, https://github.com/3stack-software/meteor-presence/blob/c8b2ea9ffccdb12a3abd05ec87bbb3546918aa9c/lib/server/presence.coffee#L26. Sorry for the false alarm.

mquandalle added a commit to mquandalle/meteor-presence that referenced this issue Oct 30, 2015
This fixes a bug when both `3stack:presence` and `meteorhacks:fast-render` are added on the same application.

See kadirahq/fast-render#146 (comment) for more details.
@arunoda
Copy link
Contributor

arunoda commented Oct 30, 2015

No problem.
On 2015 ඔක් 30, සිකු at පෙ.ව. 6.42 Maxime Quandalle <
notifications@github.com> wrote:

Closed #146 #146.


Reply to this email directly or view it on GitHub
#146 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants