Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ignoring paths #389

Closed
wants to merge 1 commit into from
Closed

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Nov 8, 2015

Fixes #387.

@arunoda
Copy link
Contributor

arunoda commented Nov 9, 2015

Thanks for the PR.
We've hacked page.js in many ways. I don't like to add more hacks to it.
And current page.js's ignore path API looks very nice and adequate for all apps.

But we can add a good entry in the README.

@mitar
Copy link
Contributor Author

mitar commented Nov 9, 2015

And current page.js's ignore path API looks very nice and adequate for all apps.

Hm, definitely not for all apps. Like, what would be a good pattern to say that all links under /uploads should be ignored by page.js? I do not think it can be any nicer than this.

@arunoda
Copy link
Contributor

arunoda commented Nov 9, 2015

But adding a HTML tag is not that hard.

@mitar
Copy link
Contributor Author

mitar commented Nov 9, 2015

In all links which can potentially be rendered on the site? So now when I have a HTML rich-text editor I have to parse the HTML, check all the links, check if any of the links are pointing to /uploads directory, modify the link and add a HTML attribute, and then hope this will not confuse the rich-text editor next time I will open it up again to continue editing?

@arunoda
Copy link
Contributor

arunoda commented Nov 9, 2015

So it's still doable.
Sorry I'm not going to take this PR.
But I like to add the docs to README.

@arunoda arunoda closed this Nov 12, 2015
mitar added a commit to peerlibrary/flow-router that referenced this pull request Dec 6, 2015
Because this pull request/feature was declined to be merged in upstream:
kadirahq#389
@mitar
Copy link
Contributor Author

mitar commented Dec 6, 2015

Sorry, I need this feature. I created a fork: https://atmospherejs.com/peerlibrary/flow-router

@mitar
Copy link
Contributor Author

mitar commented Feb 28, 2016

@sahanDissanayake
Copy link

sahanDissanayake commented Jun 8, 2016

did this happen ?

My scenario is that I wanna serve a static JS file from S3 when a user hit http://example.com/embed.js

With the latest Flowrouter is this doable ?

@sahanDissanayake
Copy link

should i just use https://github.com/meteorhacks/picker ?

@mitar
Copy link
Contributor Author

mitar commented Jun 8, 2016

No. I have a fork above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants