-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Komposer 2.x #123
Comments
We should also look at documenting how to use recompose if needed. |
Expecting |
Nice @arunoda! Looking forward to it |
I'm HIGHLY opposed to using For that matter, I think the args that are passed in should be an object rather than ordered parameters: const dataLoader = ({props, onData, onError, context}) => {
// Fetch from the data.
return aa.subscribe();
}; This API is much cleaner and you can simply ignore the arguments that you don't use. With the example you give using arrow functions the |
How soon will v2 merge to master? |
Hm, I think the old pattern/usage was simpler. |
by the way, react-komposer share some functionality with https://github.com/acdlite/recompose (like composeAll / merge is mostly the same like recompose' compose). Did you think about using it under the hood? |
@macrozone we only use a single feature of recompose which is We use react-komposer for data loading, but after that it's possible to use recompose or use recomposed UI components with react-komposer. |
Closing since I've released it. But feel free to open new issues for questions. |
We've been pretty busy with some internal apps these days. Sorry for not updating.
When we are building it and looking at some of these issues, I think we need to re-think about the API.
Here's what we are looking to have in 2.x (Which will be out pretty soon).
The text was updated successfully, but these errors were encountered: