Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symbol type Workaround #35

Merged
merged 5 commits into from Aug 17, 2022
Merged

Add symbol type Workaround #35

merged 5 commits into from Aug 17, 2022

Conversation

manuth
Copy link
Contributor

@manuth manuth commented Jun 29, 2022

Currently, this module doesn't work when using with typescript and its --build or -b command line argument.
This error has been described in #34.

Changes made in this PR will patch the type declarations in a way to prevent said errors while still maintaining the ability to query comments using the newly introduced CommentSymbol type.

Merging this PR will fix #34

Remark:
This workaround will be obsolete once the related PR on TypeScript's side has been reased:
microsoft/TypeScript#49746

@manuth manuth changed the title README: add remarks about changes Add symbol type Workaround Jul 9, 2022
@kaelzhang kaelzhang merged commit 80fcd67 into kaelzhang:master Aug 17, 2022
kaelzhang added a commit that referenced this pull request Aug 17, 2022
@kaelzhang
Copy link
Owner

Landed in 4.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS2411: Property '[Symbol.unscopables]' of type is not assignable
2 participants