Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isPathValid does not catch invalid asterisks patterns #60

Closed
maxwoo-houzz opened this issue May 21, 2020 · 1 comment
Closed

isPathValid does not catch invalid asterisks patterns #60

maxwoo-houzz opened this issue May 21, 2020 · 1 comment
Labels
not-a-bug

Comments

@maxwoo-houzz
Copy link

according to the gitignore spec, more than two asterisks ** should not be valid, so something like .abc/***** should not be allowed. However, ignore.isPathValid('.abc/*****') returns true.
@kaelzhang
Copy link
Owner

isValidPath is not used to check ignore patterns but paths

maxwoo-houzz added a commit to maxwoo-houzz/stylelint-no-restricted-imports that referenced this issue May 22, 2020
@maxwoo-houzz
removed pattern validation
15440e5 
doesn't work, see kaelzhang/node-ignore#60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-a-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaelzhang @maxwoo-houzz