Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of filter #36

Merged
merged 1 commit into from Apr 26, 2018
Merged

Conversation

sandersn
Copy link
Contributor

The source of filter is

  filter (paths) {
    return make_array(paths).filter(path => this._filter(path))
  }

So I think it is pretty obvious that filter's type is string[] => string[].

Also remove redundant types from filter's JSDoc in index.d.ts.

Also remove redundant types from filter's JSDoc
@kaelzhang kaelzhang merged commit b1a0200 into kaelzhang:master Apr 26, 2018
@kaelzhang kaelzhang mentioned this pull request Apr 26, 2018
@kaelzhang
Copy link
Owner

Thanks! Landed in 3.3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants