Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tap + Internal Caching Fixes #74

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Tap + Internal Caching Fixes #74

merged 2 commits into from
Nov 3, 2021

Commits on Nov 3, 2021

  1. Fix weird tap testing failures 

    Also adds 16.x (latest LTS) to testing suite.

xref: tapjs/tapjs#624

The issue is closed, but it is still being reported.

xref: nodejs/citgm#852 (comment)

This is the fix being used in this commit.
    @gfyoung
    gfyoung committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    b44d72a View commit details
    Browse the repository at this point in the history

  2. Fix case-insensitivity of internal cache 

    The internal cache really should be caching the
generated output of the reduce pattern, not
the generated RegExp object, which may not have
the right behavior for "ignorecase"
    @gfyoung
    gfyoung committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    f2f67cb View commit details
    Browse the repository at this point in the history