Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE: Topics: Save field previews into local storage #449

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

FE: Topics: Save field previews into local storage #449

wants to merge 3 commits into from

Conversation

Nilumilak
Copy link
Member

Resolves: #439

@Nilumilak Nilumilak self-assigned this Jun 20, 2024
@Nilumilak Nilumilak requested a review from a team as a code owner June 20, 2024 10:19
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress area/topics status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jun 20, 2024
@Nilumilak Nilumilak added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes area/messages and removed area/topics labels Jun 20, 2024
Leshe4ka
Leshe4ka reviewed Jul 10, 2024
View reviewed changes
frontend/src/components/Topics/Topic/Messages/MessagesTable.tsx Outdated
? setKeyFilters(payload)
: setContentFilters(payload)
}
setFilters={(payload: PreviewFilter[]) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. I think it's better to write separate function for setting filters, for better readability.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Leshe4ka
Leshe4ka approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@Leshe4ka Leshe4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leshe4ka Leshe4ka Leshe4ka approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@Nilumilak Nilumilak

Labels
area/messages scope/frontend Related to frontend changes status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FE: Topics: Save field previews into local storage
2 participants
@Nilumilak @Leshe4ka