-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/support https #6
Conversation
* and fix some bugs while testing it..
I don't think this github ci pipeline is configured correctly, hence the pipeline is failing: https://stackoverflow.com/a/67998780/381083 |
I am not sure why the CI is not working. Clearly it used to work a month ago: https://github.com/kafisatz/InfluxDBClient.jl/actions/runs/3845052229/jobs/6548750295 |
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
==========================================
- Coverage 94.02% 7.58% -86.45%
==========================================
Files 8 8
Lines 335 343 +8
==========================================
- Hits 315 26 -289
- Misses 20 317 +297
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@amanica I fixed the CI. It seems that it is working with InfluxDB 2.4, but 'latest' (2.6?) does not seem to work. Might be about default settings or http vs https. Notably I have not tested https (neither locally nor in CI). Also I can't test influxdb cloud. |
thanks for sorting out and merging! |
hi,
I'd like to use this library to connect to influxdb cloud, but for that I need https support, so I gave that a go.
In order to be backwards compatible but still allow configuring an https url, I suggest we move away from INFLUXDB_HOST to INFLUXDB_URL
I also fixed some bugs I ran into while testing this
Let me know if you need me to change anything.