-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customized topic name format #60
Comments
Hi @jkorab Actually currently this is somehow possible, if you build a topology that looks like ---
company: "company"
env: "env"
team: "team"
source: "source"
projects:
- name: "foo" this will generate topic that looks like team.company.env.source.foo.foo the only key that is mandatory in the topology is the team, because at the end of the story we need a PK for the case when there are multiple files representing a single topology so we can group. Are you thinking more about the line of adding patterns in the values that get resolved at execution time? |
The current pattern is:
might be we can add a pattern as configuration ? this might be a way to implement this. What do you think? |
I need to add this support for my customer, any opposition against implementing this using Jinja2 templates? Would allow for great flexibility for the end-user, so we don't have to keep making changes to support more use cases. Plus it's a templating engine that most people in the DevOps world are used to. |
that would be awesome, go ahead! if I can help in anyhow let me know :-) |
Just remember at some point we need a way to group multiple files into a single topology so we need to designate a PK for the grouping. |
Yeah, that's something I've been thinking through with a few of the changes. I'm looking at the idea of a context that would change based on the Base/Core, Topology file, and the project. This would be to address this issue, as well as the Vault integration, and I'd imagine more features would need this support. |
Hi @nerdynick , are you making any sharable advance on this topic? otherwise I would really like to start tracking this problem here. |
Hi @nerdynick, with #68 I have renamed team for context for a better understanding. I am sorry if this caused problems with your current work line, however I had to do that to enable a few people move forward. The change is a simple rename as context describe much better the purpose of the old team. |
related to #84 |
@nerdynick I know you are working on this, however I need to move forward with it. happy to get your feedback as well. |
Add a topicNameFormat configuration element with tokens that pull in environment variables, and also ones that correspond to the config elements. That way, if people wanted to tweak the default conventions, it's configurable.
e.g.
topicNameFormat={env.CP_ENVIRONMENT_NAME}-{team}-{source}-{project}-{topic}
The text was updated successfully, but these errors were encountered: