While you were gone... #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#3) * Don't throw exception if JuleOps is not allowed to delete topics.
* Update README.md * fix: Apply formatting, using a formatter that supports Java 17 * chore: Update dependencies * chore: Update dependencies * Update container versions * fix: Replace deprecated AssertJ method * chore: Upgrade Confluent version in workflow * fix: Replace deprecated methods * fix: Replace deprecated methods * chore: Update dependencies * fix: Extend connector path for new version of connect * fix: Revert ksqldb-server to a version that makes the test pass * fix: Correct return value from exception handler * fix: Hack around bug KAFKA-14325
The Zookeeper dependency is required for a single test method only. This PR moves all ZK* classes to src/test, and marks the zookeeper dependency as test-coped. Unfortunately, recent versions of zookeeper drag in a logback dependency, that appears to turn on global DEBUG logging. So this PR also exludes those logback dependencies. Fixes kafka-ops#548
* Excludes all Log4j2Plugins.dat from the shaded jar, to avoid Log4j2 startup problems (ERROR StatusLogger Unrecognized conversion specifier...) * Adds a log4j.properties that will be picked up by the Kafka dependencies
sverrehu
force-pushed
the
main-sverrehu
branch
from
18c8d61
to
b7c115e
Compare
* chore: Remove unused imports * docs: Remove trailing spaces
piotrsmolinski
approved these changes
Sep 12, 2023
src/test/java/com/purbon/kafka/topology/integration/MDSBaseTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/purbon/kafka/topology/integration/containerutils/ConnectContainer.java
Show resolved
Hide resolved
src/test/java/com/purbon/kafka/topology/integration/containerutils/KsqlContainer.java
Show resolved
Hide resolved
|
Thanks @sverrehu for your lovely work, while I'm kinda retired, @piotrsmolinski is helping out and he is preparing another PR, so love to get yours in. I hope that is ok for you. |
…t.java Co-authored-by: piotrsmolinski <piotr.smolinski.77@gmail.com>
Of course, Pere! |
|
Thanks again @sverrehu, merging this PR right now. @piotrsmolinski appreciate as well a ton your thoughts and help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things that we already implemented where I work. Leaving it here in a multi purpose PR in case @purbon is interested at some time in the future. It's all in my
main-sverrehubranch.--recursiveflag that allows finding topology files in subdirectories.AdminClient, instead of silencing it completely.src/testand mark thezookeeperdependency astest-scoped, since it was only used in tests, and dragged unwanted dependencies into the shaded jar. (These dependencies caused the spam of all kinds of DEBUG messages in the output.)