Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why I can not compile??? #128

Closed
yunnet opened this issue Oct 18, 2016 · 4 comments
Closed

Why I can not compile??? #128

yunnet opened this issue Oct 18, 2016 · 4 comments

Comments

@yunnet
Copy link

yunnet commented Oct 18, 2016

$ rebar3 compile
===> Verifying dependencies...
===> Fetching kafka_protocol ({pkg,<<"kafka_protocol">>,<<"0.7.3">>})
===> Download error, using cached file at c:/Users/Net/.cache/rebar3/hex/default/packages/kafka_protocol-0.7.3.tar
===> Fetching supervisor3 ({pkg,<<"supervisor3">>,<<"1.1.3">>})
===> Downloaded package, caching at c:/Users/Net/.cache/rebar3/hex/default/packages/supervisor3-1.1.3.tar
===> Fetching snappyer ({pkg,<<"snappyer">>,<<"1.1.3-1.0.4">>})
===> Downloaded package, caching at c:/Users/Net/.cache/rebar3/hex/default/packages/snappyer-1.1.3-1.0.4.tar
===> Compiling supervisor3
**===> Compiling snappyer
MAKE Version 5.2 Copyright (c) 1987, 2000 Borland
Error makefile 15: Command syntax error
Error makefile 18: Command syntax error
Error makefile 20: Command syntax error
* 3 errors during make ***
===> Hook for compile failed!

@id
Copy link
Contributor

id commented Oct 18, 2016

Looks like make 5.2 from Borland can't read our Makefile. Can you try to install http://gnuwin32.sourceforge.net/packages/make.htm and see if it works? Don't have a windows PC at hand, but I'll try to figure something out if this does not work.

Also, could you provide more details? Windows version, whether you use cygwin, etc.

@zmstone
Copy link
Contributor

zmstone commented Oct 18, 2016

Here is the on-windows guide from erlang.mk: https://erlang.mk/guide/installation.html#_on_windows
Loading nif from dll can't be supported without a significant change to Makefile and source code.

On the other hand, we should probably support a global setting to enable/disable snappy.
when disabled, kafka_protocol should not download the dependency and not compile the snappy compression/decompression clauses either.

@yunnet
Copy link
Author

yunnet commented Oct 19, 2016

Thank you for your help, I try again

@zmstone
Copy link
Contributor

zmstone commented Nov 1, 2016

@yunnet Did it work out for you?
I have tried to make snappyer dependency optional in Makefile and rebar.config.script of the library kafka_protocol, which worked for erlang.mk and rebar but not rebar3 (because it downloads dependencies recursively from hex).

If you do not need snappy compression in your project, you can try to manually remove the dependency, (also delete the entry from your project rebar.lock).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants