Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop batches in aborted transactions #316

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Drop batches in aborted transactions #316

merged 2 commits into from
Apr 25, 2019

Conversation

zmstone
Copy link
Contributor

@zmstone zmstone commented Apr 24, 2019

Drop all control batches.
And improve offset fast-forwarding when empty sets are received.

Drop all control batches.
And improve offset fast-forwarding when empty sets are received.
@zmstone zmstone requested a review from a team April 24, 2019 10:19
@coveralls
Copy link

coveralls commented Apr 24, 2019

Pull Request Test Coverage Report for Build 1055

  • 38 of 40 (95.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 79.609%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/brod_consumer.erl 10 11 90.91%
src/brod_utils.erl 28 29 96.55%
Totals Coverage Status
Change from base Build 1039: 0.5%
Covered Lines: 2038
Relevant Lines: 2560

💛 - Coveralls

@zmstone zmstone merged commit e2c4133 into master Apr 25, 2019
@zmstone zmstone deleted the drop-aborted-txn-msgs branch April 25, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants