Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: describe_groups schema #486

Merged
merged 1 commit into from Jan 13, 2022
Merged

Conversation

3duard0
Copy link
Contributor

@3duard0 3duard0 commented Jan 10, 2022

The command describe_groups in brod_cli is passing a wrong parameter group_ids, when the required schema in kafka_protocol is groups

Error when running:
./_build/brod_cli/rel/brod/bin/brod groups --ids=hello_kafka_group -b 127.0.0.1:9092

*** error:{field_missing,[{stack,[{describe_groups,0},groups]},
                          {input,[{group_ids,[<<"hello_kafka_group">>]}]}]}
[{kpro_req_lib,enc_struct,3,
               [{file,"/home/eduardo/dev/brod/_build/default/lib/kafka_protocol/src/kpro_req_lib.erl"},
                {line,459}]},
 {kpro_req_lib,encode_struct,3,
               [{file,"/home/eduardo/dev/brod/_build/default/lib/kafka_protocol/src/kpro_req_lib.erl"},
                {line,439}]},
 {kpro_req_lib,make,3,
               [{file,"/home/eduardo/dev/brod/_build/default/lib/kafka_protocol/src/kpro_req_lib.erl"},
                {line,393}]},
 {brod_utils,'-describe_groups/3-fun-0-',2,
             [{file,"/home/eduardo/dev/brod/src/brod_utils.erl"},{line,507}]},
 {kpro_brokers,with_connection,3,
               [{file,"/home/eduardo/dev/brod/_build/default/lib/kafka_protocol/src/kpro_brokers.erl"},
                {line,65}]},
 {brod_cli,do_describe_cgs,3,
           [{file,"/home/eduardo/dev/brod/src/brod_cli.erl"},{line,689}]},
 {brod_cli,describe_cgs,3,
           [{file,"/home/eduardo/dev/brod/src/brod_cli.erl"},{line,683}]},
 {brod_cli,main,5,
           [{file,"/home/eduardo/dev/brod/src/brod_cli.erl"},{line,392}]}]

This PR fixes this.

@zmstone zmstone merged commit 6410360 into kafka4beam:master Jan 13, 2022
@zmstone
Copy link
Contributor

zmstone commented Jan 13, 2022

Thank you for the fix @3duard0

@3duard0 3duard0 deleted the fix/describe_groups branch January 13, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants