Merge pull request #351 from ukrbublik/close-socket-on-error

Close socket on timeout/error
kafkaex · Jun 18, 2019 · 6297def · 6297def
2 parents 7655de9 + 014fcf2
commit 6297def
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/kafka_ex/network_client.ex b/lib/kafka_ex/network_client.ex
@@ -68,6 +68,7 @@ defmodule KafkaEx.NetworkClient do
         :ok ->
           case Socket.recv(socket, 0, timeout) do
             {:ok, data} ->
+              :ok = Socket.setopts(socket, [:binary, {:packet, 4}, {:active, true}])
               data
 
             {:error, reason} ->
@@ -78,6 +79,8 @@ defmodule KafkaEx.NetworkClient do
                 } failed with #{inspect(reason)}"
               )
 
+              Socket.close(socket)
+
               {:error, reason}
           end
 
@@ -88,11 +91,12 @@ defmodule KafkaEx.NetworkClient do
               inspect(broker.port)
             } failed with #{inspect(reason)}"
           )
+
+          Socket.close(socket)
 
           {:error, reason}
       end
 
-    :ok = Socket.setopts(socket, [:binary, {:packet, 4}, {:active, true}])
     response
   end