Merge pull request #395 from shamilish/randomize-host-to-fetch-metadata

Don't always send update metadata requests to the same broker
kafkaex · Jan 21, 2020 · c1f94e3 · c1f94e3
2 parents cabdbac + 411396b
commit c1f94e3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/kafka_ex/new/client.ex b/lib/kafka_ex/new/client.ex
@@ -442,7 +442,9 @@ defmodule KafkaEx.New.Client do
   end
 
   defp first_broker_response(request, brokers, timeout) do
-    Enum.find_value(brokers, fn broker ->
+    brokers
+    |> Enum.shuffle()
+    |> Enum.find_value(brokers, fn broker ->
       if Broker.connected?(broker) do
         try_broker(broker, request, timeout)
       end

diff --git a/lib/kafka_ex/server.ex b/lib/kafka_ex/server.ex
@@ -974,7 +974,9 @@ defmodule KafkaEx.Server do
       end
 
       defp first_broker_response(request, brokers, timeout) do
-        Enum.find_value(brokers, fn broker ->
+        brokers
+        |> Enum.shuffle()
+        |> Enum.find_value(fn broker ->
           if Broker.connected?(broker) do
             # credo:disable-for-next-line Credo.Check.Refactor.Nesting
             case NetworkClient.send_sync_request(broker, request, timeout) do