Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kafka 0.11 for tests #355

Merged
merged 10 commits into from Jul 8, 2019
Merged

Use kafka 0.11 for tests #355

merged 10 commits into from Jul 8, 2019

Conversation

dantswain
Copy link
Collaborator

It's impossible to test many of the modernization efforts that are being
requested with Kafka 0.10. 0.11 introduces many of the changes that are
necessary.

It appears 0.11 takes a bit longer to coordinate consumer groups, so I had to add timeout options to some of the ConsumerGroup.Manager calls. I also made session_timeout_padding a configurable setting.

Copy link
Member

@bjhaid bjhaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joshuawscott joshuawscott merged commit 08e91ca into master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants