New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include topic and partition in message struct #360

Merged

dantswain merged 4 commits into kafkaex:master from thiamsantos:ts-include-topic-in-message

Aug 31, 2019

Contributor

thiamsantos commented Aug 27, 2019 •

edited

Motivation

In our current use case, we want to consume multiple topics, with the consumer group supervisor. To do that we need a way to identify the message to each topic reaching the handler.

Proposed solution

Include the topic key in the Protocol.Fetch.Message struct of the response.
Include the partition key in the Protocol.Fetch.Message struct of the response.

Related

thiamsantos added 4 commits

August 27, 2019 13:06


          Include topic in message

8d61270


          Remove IO.inspect

2c9ebc1


          Update tests

5123c03


          Include partition in Message struct

b9dd02d

thiamsantos changed the title ~~Include topic in message struct~~ Include topic and partition in message struct

dantswain approved these changes

View reviewed changes

Collaborator

dantswain left a comment

This seems like a good change. I don't think it will cause any compatibility issues because we're only adding fields to a struct. @joshuawscott or @jbruggem can you double check my logic?

joshuawscott approved these changes

View reviewed changes

Member

joshuawscott left a comment

👍

dantswain merged commit 8127fa6 into kafkaex:master

Contributor Author

thiamsantos commented Sep 1, 2019

Thanks for the review ❤️

@dantswain @joshuawscott Do you plan to release a new hex version with these changes soon?

joshuawscott mentioned this pull request

Add Topic and Partition ID to Protocol.Fetch.Message #358

Closed

Member

joshuawscott commented Jul 14, 2020

@thiamsantos my apologies for the long release delay - I'm going to have a new release today or tomorrow (depending on how long it takes to get through the release notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment