Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning about Supervisor.terminate_child with PID #430

Merged
merged 1 commit into from Jan 7, 2021

Conversation

colinsmetz
Copy link
Contributor

Hello!

When using KafkaEx with Elixir 1.11, this warning appears very frequently:

warning: Supervisor.terminate_child/2 with a PID is deprecated, please use DynamicSupervisor instead
  (elixir 1.11.2) lib/supervisor.ex:857: Supervisor.terminate_child/2
  (stdlib 3.14) gen_server.erl:727: :gen_server.try_terminate/3
  (stdlib 3.14) gen_server.erl:912: :gen_server.terminate/10
  (stdlib 3.14) proc_lib.erl:226: :proc_lib.init_p_do_apply/3

This PR removes those deprecation warnings by applying the fix suggested in the message.

@sourcelevel-bot
Copy link

Hello, @colinsmetz! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

Copy link
Collaborator

@jbruggem jbruggem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(disclosure: Colin is a direct colleague if mine).

@jbruggem
Copy link
Collaborator

jbruggem commented Jan 7, 2021

Given that the change is trivial and that all the tests passed, I'll go ahead and merge this.

@jbruggem jbruggem merged commit 024b3af into kafkaex:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants