Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Local Artist Image #254

Closed
luxdi opened this issue Aug 3, 2023 · 4 comments · Fixed by #500
Closed

[Feature Request]: Local Artist Image #254

luxdi opened this issue Aug 3, 2023 · 4 comments · Fixed by #500
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@luxdi
Copy link

luxdi commented Aug 3, 2023

Scope

GUI

What problem

For as long as I can remember the pull from last.fm for the Artist Image just gives a big white star.

Feature

I have a folder.jpg file for the artist in every one of my artist folders. Would be possible to be able to use locally stored files for the Artist Image instead of the failed call to last.fm which generates the white star.

@luxdi luxdi added the enhancement New feature or request label Aug 3, 2023
@The-Exterminator
Copy link

The-Exterminator commented Aug 9, 2023

or take the image from spotify, tidal or fanart.tv

@fault1er1
Copy link

And please... for searching purposes use the Artist Name from the tags and not the filename from the filesystem.

@kagemomiji kagemomiji self-assigned this Aug 29, 2023
@kagemomiji kagemomiji added this to the 11.1.4 milestone Aug 29, 2023
@boudafc
Copy link

boudafc commented May 11, 2024

or take the image from spotify, tidal or fanart.tv

It seems to be a better idea. I have made a little research and after subscribing to the API from last.fm, it seems to return a "star" (https://lastfm.freetls.fastly.net/i/u/300x300/2a96cbd8b46e442fc41c2b86b821562f.png) as image even if there is really an image for the artist in last.fm website.

kagemomiji added a commit that referenced this issue Jun 13, 2024
#254 Support local artist image to replace LastFM artist image
kagemomiji added a commit that referenced this issue Jun 13, 2024
kagemomiji added a commit that referenced this issue Jun 13, 2024
@fault1er1
Copy link

fault1er1 commented Jun 16, 2024

Hi @kagemomiji ,

thank you for the implementation of this useful feature!

Is it possible to change the display of the images in such a way that the aspect ratio is preserved? Unfortunately, a lot of band logos/pictures are now distorted. Just like the album covers, when it's a cover of a tape or another not-cd aspect ratio.

Plus, using the bandname from the tags for the last.fm infos would be excellent, because I'm using filesystem-names without spaces to prevent charset-failures on different operating systems. Currently, only one-word bands are found correctly.

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

5 participants