Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setTaskData not called #452

Closed
m7yJpNXY opened this issue Dec 19, 2023 · 2 comments · Fixed by #495
Closed

setTaskData not called #452

m7yJpNXY opened this issue Dec 19, 2023 · 2 comments · Fixed by #495
Labels
bug pri1 released Issue has been released

Comments

@m7yJpNXY
Copy link

jdbcCustomization.setTaskData is called in JdbcTaskRepository::createIfNotExists but not in JdbcTaskRepository::replace or JdbcTaskRepository::rescheduleInternal. Shouldn´t it be called for the latter two as well?

@kagkarlsson
Copy link
Owner

I believe you are correct, yes. Good catch! Currently there are only one implementation of that in db-scheduler, but if anyone tries to override the way data is stored in the table, there will be trouble..

Current only implementation:

  @Override
  public void setTaskData(PreparedStatement p, int index, byte[] value) throws SQLException {
    p.setObject(index, value);
  }

@kagkarlsson
Copy link
Owner

🎉 This issue has been resolved in v14.0.1 (Release Notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug pri1 released Issue has been released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants