Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

353 pause scheduler #356

Merged
merged 4 commits into from
Mar 1, 2023
Merged

Conversation

tkosgrabar
Copy link

@tkosgrabar tkosgrabar commented Feb 1, 2023

Brief, plain english overview of your changes here

Naive implementation of paused state

Fixes

#353

Reminders

  • Added/ran automated tests
  • Update README and/or examples

cc @kagkarlsson

import com.github.kagkarlsson.scheduler.task.TaskInstance;
import com.github.kagkarlsson.scheduler.task.TaskInstanceId;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rather avoid this import diff..

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kagkarlsson
Copy link
Owner

Looks ok on first glance

Copy link
Owner

@kagkarlsson kagkarlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@tkosgrabar
Copy link
Author

nice, when do you plan to merge and release it ?

@kagkarlsson kagkarlsson merged commit ff5708a into kagkarlsson:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants