Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use varchar instead of (deprecated) text column type for MSSQL schema #455

Merged
merged 1 commit into from
Jan 13, 2024
Merged

fix: use varchar instead of (deprecated) text column type for MSSQL schema #455

merged 1 commit into from
Jan 13, 2024

Conversation

aukevanleeuwen
Copy link
Contributor

  • Updated the MSSQL schema to not use the (deprecated) text data type.
  • Use varchar(5) since, the max length is 50 according to Official database schema? (MSSQL) #453
  • Some alignment in casing and spacing

Fixes

#454

Reminders

  • Added/ran automated tests
  • Update README and/or examples
  • Ran mvn spotless:apply

cc @kagkarlsson

kagkarlsson
kagkarlsson approved these changes Jan 13, 2024
View reviewed changes
Copy link
Owner

@kagkarlsson kagkarlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing 👍

@kagkarlsson kagkarlsson merged commit a27383a into kagkarlsson:master Jan 13, 2024
5 checks passed
@kagkarlsson
Copy link
Owner

🎉 This issue has been resolved in v14.0.0 (Release Notes)

@kagkarlsson kagkarlsson added the released Issue has been released label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kagkarlsson kagkarlsson kagkarlsson approved these changes

Assignees
No one assigned
Labels
released Issue has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aukevanleeuwen @kagkarlsson