Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build on macos #45

Merged
merged 1 commit into from Nov 20, 2020
Merged

fix build on macos #45

merged 1 commit into from Nov 20, 2020

Conversation

gaul
Copy link
Collaborator

@gaul gaul commented Mar 24, 2020 •
edited

Fixes #10.

@gaul gaul mentioned this pull request Mar 24, 2020
Closed
@gaul
Copy link
Collaborator Author

gaul commented Mar 24, 2020

This still has some test failures, notably large_write and read_modify_write, but it should be good enough for someone else to continue debugging.

@gaul gaul force-pushed the macos branch 2 times, most recently from 8badae4 to 6a21ed3 Compare March 24, 2020 13:07
@gaul
Copy link
Collaborator Author

gaul commented Mar 25, 2020

I think there is a better way to do the conditional compilation at the use level; let me investigate.

@gaul
Copy link
Collaborator Author

gaul commented Mar 25, 2020

I think there is a better way to do the conditional compilation at the use level; let me investigate.

Done.

@gaul
Copy link
Collaborator Author

gaul commented Apr 19, 2020

Fixed remaining failing tests on macOS.

@gaul gaul merged commit be24fd5 into kahing:master Nov 20, 2020
@gaul gaul deleted the macos branch November 20, 2020 10:46
@gaul gaul mentioned this pull request Nov 20, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error when compiling on macOS
2 participants
@gaul @yjh0502