firestoreのセキュリティルール追加 #3
Merged
+37
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
めっちゃ良い感じです！ |
kahirokunn
reviewed
Jul 26, 2019
firestore.rules
Outdated
| && isUserInRoom(roomId) | ||
|
|
||
| match /messages/{messageId} { | ||
| allow read, create: if isAuthenticated() |
There was a problem hiding this comment.
readはisSentFromCorrectIdいらないと思います！
There was a problem hiding this comment.
readとcreateで分けようと思います！
| } | ||
|
|
||
| match /accounts/{account} { | ||
| allow read, write: if isAuthenticated() |
There was a problem hiding this comment.
すいません、/accounts/{account}にはやっぱ何も生やさない事にしたので、read writeどちらもできないようにいただけたらと。。。(´；ω；｀)
There was a problem hiding this comment.
すいません、何も生やさないっていうのはどういう意味でしょうか・・？
その中のunreadMessages（unreadMessageSegmentsに変わった？）も何もallowしないほうがいいですか？
There was a problem hiding this comment.
/accounts/{account}はunreadMessagesのサブコレクションを持つだけのドキュメントになるってことです！
There was a problem hiding this comment.
なるほど！！わかりましたありがとうございます！
|
createdAtを守るっていうのはこのやり方で大丈夫ですか？ |
|
そういうことです！ |
firestoreのruleを実際の構造に合わせて修正
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
firestoreのセキュリティルールを追加しました。
補足
最新のcommon-messengerの
src/firebase/collectionSchema.tsのfirestoreの設計に合わせて実装してあるので、今のfirestoreには使えないです。一旦↓のコメントの部分を実装しました。
https://www.pivotaltracker.com/story/show/167423193/comments/204945961
残りは別ストーリで実装予定です。
https://www.pivotaltracker.com/story/show/167483102
このPRに関連するissue
Pivotal TrackerのURL
https://www.pivotaltracker.com/story/show/167423193