Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent quotation and comment style #54

Open
1 of 2 tasks
kahmali opened this issue May 2, 2015 · 2 comments
Open
1 of 2 tasks

Use consistent quotation and comment style #54

kahmali opened this issue May 2, 2015 · 2 comments

Comments

@kahmali
Copy link
Owner

kahmali commented May 2, 2015

@dandv
Copy link
Contributor

dandv commented May 2, 2015

Use single quotes except in interpolated strings (should at least consider making all strings double quoted, for even more consistency)

In Perl, which also interpolates double-quoted but not single-quotes strings, I've always used single quotes whenever interpolation was not expected, and double quotes only when it was. Apostrophes in strings were pesky, which is why I preferred more format errors ("Could not read file" vs. "Couldn't read file").

@kahmali
Copy link
Owner Author

kahmali commented May 2, 2015

Thanks for your input @dandv! I was definitely leaning in that direction, as it's the convention I was trying to follow (but clearly failed to do so). Java is one of my most familiar languages, so I accidentally drop those double quoted strings in for no apparent reason sometimes. Just an old habit dying hard, I suppose.

I'll adopt the single-quoted-unless-interpolated convention, and probably even add in a super simple style guideline to the contributing doc and include that info there as well.

kahmali added a commit that referenced this issue May 13, 2015
- Resolve task in Issue #54
- Use single-quotes everywhere except in interpolated strings
@kahmali kahmali modified the milestone: v0.7.0 Jun 1, 2015
kahmali added a commit that referenced this issue Jun 21, 2015
- Resolve task in Issue #54
- Use single-quotes everywhere except in interpolated strings
kahmali added a commit that referenced this issue Jul 2, 2015
- Resolve task in Issue #54
- Use single-quotes everywhere except in interpolated strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants