fix: pin Sphinx version #1511
Merged
fix: pin Sphinx version #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sphinxawesome-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Sep 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Sphinx 7, copying the static assets happens BEFORE the
doctree-resolvedevent is emitted.Because we update the globalcontext with the DocSearch configuration when handling this event, the
docsearch_config.jsfile ends up empty. DocSearch is NOT being added.In Sphinx 6, copying the static files happens AFTER the
doctree-resolvedevent is emitted.The global context has the DocSearch configuration, the
docsearch_config.jsfile is NOT empty, and DocSearch works as expected.Properly supporting the latest version of Sphinx is a bit of a challenge due to the many expected and unexpected changes. Until I figure it out, I won't support Sphinx 7.