Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#definitions vs #/definitions in schema.json #3

Closed
thomasborgen opened this issue Mar 27, 2021 · 0 comments · Fixed by #5
Closed

#definitions vs #/definitions in schema.json #3

thomasborgen opened this issue Mar 27, 2021 · 0 comments · Fixed by #5

Comments

@thomasborgen
Copy link
Contributor

I wonder why both of these works, but it should be fixed.

#definitions/iterable and #/definitions/attribute

"iterables": {
    "type": "array",
    "items": {
        "$ref": "#definitions/iterable"
    },
    "default": []
},
"branching_attributes": {
    "type": "array",
    "items": {
        "type": "array",
        "items": {
            "$ref": "#/definitions/attribute"
        }
    },
    "default": []
}
@thomasborgen thomasborgen linked a pull request Apr 5, 2021 that will close this issue
Patch/fix issues in schema #5
Merged
thomasborgen added a commit that referenced this issue Apr 5, 2021
@thomasborgen
Patch: closes: #3 - Also makes schema more explicit
4f713db 
* use already loaded SCHEMA from kaiba.schema instead of reading file in tests
* Make sure that mappings is required based on if 'default' is present or not, and both should of course have 'name' required
* Make sure we have at least 1 item in mappings if default is not provided
* Add patch entry in CHANGELOG
* bump patch in pyproject
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch/fix issues in schema kaiba-tech/kaiba
1 participant
@thomasborgen