Conceal characters colors not set

[RicherMans]

Hey there,
I love that theme but had for quite some time a problem with it, that it renders conceal characters with wrong colors( by default DarkGrey ):

I checked the documentation for neovim and vim and found the reason:

hi Conceal guibg=material guifg=material

Fixes it, but doesn't look super good. If you have time, could you tell me which colors should be appropriate ?

[kaicataldo]

Hey, I'm currently on vacation, but happy to take a look when I get back.

Edit: I'd like to actually take the time to do this right, but if you wanted a quick fix in the interim you should be able to add the following line in this file for a quick fix:

call s:HL('Conceal', s:gray4, '', '')

If you don't like the color defined by s:gray4, you can use any of the other defined colors or provide your own hex color code.

I'll take a look when I'm back from my vacation and can do a proper fix :)

[kaicataldo]

I've just done a major rewrite of the full theme. Is this still an issue?

[RicherMans]

Hey there,
unfortunately yes, still the same as before, but the theme looks much better now!

[kaicataldo]

Thanks for the kind words. I’ll try to get a patch in to fix this today.

[kaicataldo]

@RicherMans Can you give me reproduction steps? I'm realizing that I don't use Conceal characters in any of the work I do (which is why these colors aren't set!).

[RicherMans]

Hey sure, as far as I am concerned, just need in your ~/.config/nvim/init.vim to add:

Plug 'vim-pandoc/vim-pandoc-syntax'

setlocal conceallevel=2
let g:pandoc#syntax#conceal#use = 1

and then just open any .md file.

Moreover, I cursorcolumn and cursorrow seem a bit weird with that black color:

[kaicataldo]

Great, thanks - I'll see if I can fix that up.

The CursorLine color is intended - it matches the original theme. I set CursorColumn to match, which I think makes sense. I don't set cursorcolumn myself, so this is my first time actually seeing it. How do other themes typically handle this?

[kaicataldo]

This should now be fixed by b23a99b.

I also update the fold colors so that they wouldn't conflict with the relative number color.

Please confirm if you get a chance!

[RicherMans]

They there,
yeah is somewhat fixed, before all conceal characters had a different background color than the theme, but now they are nearly invisible e.g.,:

Compare with e.g., one theme:

Also since the revamp, the error bar to the left is weirdly colored and symbols rather invisible:

[kaicataldo]

We can definitely add a background color to Conceal characters if that's what others themes tend to do. As far the line numbers go, I changed it to match the VS Code themes.

Edit: I intentionally made the Conceal characters unobtrusive, since they're not actual syntax. Maybe that was a bad assumption - again, I don't really use them.

[kaicataldo]

I'm going to go ahead and close this issue because the bug is fixed (Conceal not being set). Totally open to having discussions around changing colors, but I think it would be helpful to do that on a new issue (or on this PR). I'm still fixing a few regressions from the rewrite, and I think it's useful to distinguish regressions for enhancements!