Odd Highlighting On Greek and Sub/Superscripts #149

duncanam · 2019-04-10T16:42:07Z

After being able to successfully install and use Nord on vim quite nicely, I did notice a quirky thing that may or may not be intentional and I was wondering if there was a setting to turn it off or if it was indeed a bug. I am using a plugin in vim that will render some of my LaTeX expressions as Greek characters inline, and will apply sub and superscripts to them. The Nord theme seems to highlight these:

Current output: highlights Greek and sub/superscript
Desired output: no highlighting of Greek and sub/superscript

Is there anything I can do about this, or is just outright unsupported (which is fine too, although it would be neat if there was a solution).

arcticicestudio · 2019-04-10T18:59:46Z

It is more likely that the plugin uses custom syntax keys. This would require to add support for them to Nord to make it work properly. Could you please post the name and/or the link to the GitHub repository of the plugin?

duncanam · 2019-04-10T19:26:23Z

@arcticicestudio Certainly, it's Vimtex, and found here:
https://github.com/lervag/vimtex

Anything else I can do to help?

duncanam · 2019-04-24T19:06:19Z

Well, I reached out to @gillescastel and he said to add hi Conceal ctermbg=none in my .vimrc and this worked for me. I no longer have the odd highlighting and everything is working as expected!

arcticicestudio · 2019-04-24T19:29:29Z

@duncanam Nice to hear it works fine now 🎉
I haven't got the time to take a look into this, but the solution will also help other users facing the same problem. ~~I've added a note to the backlog to add it to Nord Vim's docs/troubleshooting guide 😄~~
→ This has been documented in #256 and solved in #261.

xarthurx · 2020-07-02T19:42:46Z

hi Conceal ctermbg=none doesn't work for me here.
Neovim for Windows 10.

I found some post here:
kaicataldo/material.vim#12
for the 'material` theme, as they add some defined colour to the scheme.

Could we also do it for Nord?

Bobby-Huggins · 2021-03-12T18:09:39Z

For anyone else running into this issue:

hi Conceal ctermbg=none didn't work for me, because I am using a gui version (gVim on Windows 10).
However, hi Conceal guibg=NONE works, but only if it comes after set background=dark

The full theme section of my _vimrc is then:

if (has("termguicolors"))
  set termguicolors
endif
colorscheme nord
set background=dark
hi Conceal guibg=NONE

nikinbaidar · 2021-04-20T14:41:19Z

Well, I reached out to @gillescastel and he said to add hi Conceal ctermbg=none in my .vimrc and this worked for me. I no longer have the odd highlighting and everything is working as expected!

This works perfect.

The `Conceal` group was not supported which could have led to rendering problems for (Unicode) characters that require special encoding like the ones from the Greek alphabet [1] that are often used in LaTeX [3] or Pandoc [4] documents. These characters were highlighted with the default background color which makes them kind of unreadable with the theme foreground color. See `:help conceal` and `:help concealcursor` for more details about concealing in Vim. To fix the problem, the `Conceal` group has been added with its background color set to `NONE` for GUI and terminal mode to either use the terminal default background color or let loaded scripts apply custom styles based on the current runtime context. The problem has been reported in GH-149, GH-207 and GH-211 with LaTeX and Pandoc being used by the reporters. PR GH-220 adds support for vim-pandoc/vim-pandoc-syntax [5] specific highlighting groups and can be merged after adding basic support for `Conceal`. [1]: https://en.wikipedia.org/wiki/Greek_alphabet [2]: https://www.overleaf.com/learn/latex/mathematical_expressions [3]: https://www.latex-project.org [4]: https://pandoc.org [5]: https://github.com/vim-pandoc/vim-pandoc-syntax Co-authored-by: Sven Greb <development@svengreb.de> GH-256

The `Conceal` group was not supported which could have led to rendering problems for (Unicode) characters that require special encoding like the ones from the Greek alphabet [1] that are often used in LaTeX [3] or Pandoc [4] documents. These characters were highlighted with the default background color which makes them kind of unreadable with the theme foreground color. See `:help conceal` and `:help concealcursor` for more details about concealing in Vim. To fix the problem, the `Conceal` group has been added with its background color set to `NONE` for GUI and terminal mode to either use the terminal default background color or let loaded scripts apply custom styles based on the current runtime context. The problem has been reported in GH-149, GH-207 and GH-211 with LaTeX and Pandoc being used by the reporters. PR GH-220 adds support for vim-pandoc/vim-pandoc-syntax [5] specific highlighting groups and can be merged after adding basic support for `Conceal`. [1]: https://en.wikipedia.org/wiki/Greek_alphabet [2]: https://www.overleaf.com/learn/latex/mathematical_expressions [3]: https://www.latex-project.org [4]: https://pandoc.org [5]: https://github.com/vim-pandoc/vim-pandoc-syntax Co-authored-by: Sven Greb <development@svengreb.de> Closes GH-256

arcticicestudio · 2021-05-29T07:43:43Z

@duncanam @xarthurx @Bobby-Huggins @nikinbaidarr Thanks for your help 👍
The problem has been documented in #256 ⇄ #261 (⊶ f3f28b9) and will be shipped in version 0.16.0.

The `Conceal` group was not supported which could have led to rendering problems for (Unicode) characters that require special encoding like the ones from the Greek alphabet [1] that are often used in LaTeX [3] or Pandoc [4] documents. These characters were highlighted with the default background color which makes them kind of unreadable with the theme foreground color. See `:help conceal` and `:help concealcursor` for more details about concealing in Vim. To fix the problem, the `Conceal` group has been added with its background color set to `NONE` for GUI and terminal mode to either use the terminal default background color or let loaded scripts apply custom styles based on the current runtime context. The problem has been reported in nordthemeGH-149, nordthemeGH-207 and nordthemeGH-211 with LaTeX and Pandoc being used by the reporters. PR nordthemeGH-220 adds support for vim-pandoc/vim-pandoc-syntax [5] specific highlighting groups and can be merged after adding basic support for `Conceal`. [1]: https://en.wikipedia.org/wiki/Greek_alphabet [2]: https://www.overleaf.com/learn/latex/mathematical_expressions [3]: https://www.latex-project.org [4]: https://pandoc.org [5]: https://github.com/vim-pandoc/vim-pandoc-syntax Co-authored-by: Sven Greb <development@svengreb.de> Closes nordthemeGH-256

arcticicestudio added scope-compatibility type-support labels Apr 10, 2019

arcticicestudio added the status-pending label Apr 10, 2019

duncanam closed this as completed Apr 24, 2019

arcticicestudio added resolution-user-side and removed status-pending labels Apr 24, 2019

xarthurx mentioned this issue Jul 2, 2020

conceal color cannot be changed #211

Closed

arcticicestudio mentioned this issue May 9, 2021

Conceal highlighting group support #256

Closed

arcticicestudio mentioned this issue May 28, 2021

Conceal highlighting group support #261

Merged

arcticicestudio added context-syntax scope-quality type-feature and removed resolution-user-side type-support labels Jun 9, 2021

arcticicestudio added this to the 0.16.0 milestone Jun 9, 2021

svengreb added resolution-relocated type-support and removed type-feature labels Feb 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Odd Highlighting On Greek and Sub/Superscripts #149

Odd Highlighting On Greek and Sub/Superscripts #149

duncanam commented Apr 10, 2019

arcticicestudio commented Apr 10, 2019

duncanam commented Apr 10, 2019

duncanam commented Apr 24, 2019

arcticicestudio commented Apr 24, 2019 •

edited

xarthurx commented Jul 2, 2020

Bobby-Huggins commented Mar 12, 2021

nikinbaidar commented Apr 20, 2021

arcticicestudio commented May 29, 2021

Odd Highlighting On Greek and Sub/Superscripts #149

Odd Highlighting On Greek and Sub/Superscripts #149

Comments

duncanam commented Apr 10, 2019

arcticicestudio commented Apr 10, 2019

duncanam commented Apr 10, 2019

duncanam commented Apr 24, 2019

arcticicestudio commented Apr 24, 2019 • edited

xarthurx commented Jul 2, 2020

Bobby-Huggins commented Mar 12, 2021

nikinbaidar commented Apr 20, 2021

arcticicestudio commented May 29, 2021

arcticicestudio commented Apr 24, 2019 •

edited