Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HTML syntax to better match Material Theme #50

Closed
wants to merge 1 commit into from

Conversation

lmlorca
Copy link
Contributor

@lmlorca lmlorca commented Jul 24, 2020

No description provided.

@lmlorca
Copy link
Contributor Author

lmlorca commented Jul 24, 2020

It seems it also affects html tags in PHP, so this change should also improve the syntax of templating engines that share the same base html vim syntax groups.

@kaicataldo
Copy link
Owner

Mind adding a screenshot for posterity?

@lmlorca
Copy link
Contributor Author

lmlorca commented Jul 29, 2020

Sorry I posted the result in the issue I opened but not here.

Darker:

Before:
2020-07-29-14:45:07

Now:
2020-07-29-14:45:37

Ocean:

Before:
2020-07-29-14:55:25

Now:
2020-07-29-14:47:41

Lighter:

Before:
2020-07-29-14:49:50

Now:
2020-07-29-14:50:03

Palenight:

Before:
2020-07-29-14:52:32

Now:
2020-07-29-14:52:45

So basically it improves basic HTML support by making the tags and the attributes different. Also it follows closer the original theme as well.

@lmlorca lmlorca mentioned this pull request Jul 29, 2020
@kaicataldo
Copy link
Owner

kaicataldo commented Jul 30, 2020

Oh no, I didn’t mean to close this pull request. So sorry about that. Do you mind reopening it?

@lmlorca lmlorca deleted the html-syntax branch August 9, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants