Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type check mailers #108

Merged
merged 6 commits into from Nov 7, 2023
Merged

Type check mailers #108

merged 6 commits into from Nov 7, 2023

Conversation

tk0miya
Copy link
Contributor

@tk0miya tk0miya commented Nov 6, 2023

Note: This contains #105

unasuke
unasuke reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@unasuke unasuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but please wait a moment....

@tk0miya
Copy link
Contributor Author

tk0miya commented Nov 7, 2023

just rebased.

unasuke
unasuke approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@unasuke unasuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@unasuke unasuke merged commit 9a8c1b7 into kaigionrails:main Nov 7, 2023
2 checks passed
@tk0miya tk0miya deleted the typing_mailers branch November 7, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unasuke unasuke unasuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tk0miya @unasuke