Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBS: Add types for Announcement::ActiveRecord_Relation#published #110

Merged
merged 2 commits into from Nov 7, 2023

Conversation

tk0miya
Copy link
Contributor

@tk0miya tk0miya commented Nov 6, 2023

As a preparation of giving types to controllers, this adds types for Announcement::ActiveRecord_Relation#published manually because current rbs_rails does not support Rails7 style enums. It should be removed if rbs_rails will support it in the future.

refs: pocke/rbs_rails#268

As a preparation of giving types to controllers, this adds types for
`Announcement::ActiveRecord_Relation#published` manually because
current rbs_rails does not support Rails7 style enums. It should be
removed if rbs_rails will support it in the future.

refs: pocke/rbs_rails#268
Copy link
Contributor

@unasuke unasuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍 👍

@unasuke unasuke merged commit 558e621 into kaigionrails:main Nov 7, 2023
2 checks passed
@tk0miya tk0miya deleted the typing_models_enum branch November 7, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants