Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbs: Update rbs gem and rbs collection #144

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

tk0miya
Copy link
Contributor

@tk0miya tk0miya commented Jan 25, 2024

Update rbs gem to v3.4 and rbs collection.

Note: some shim types are removed because they have been merged into the gem_rbs_collection repo.

Update rbs gem to v3.4 and rbs collection.

Note: some shim types are removed because they have been merged into the
gem_rbs_collection repo.
@@ -31,7 +31,7 @@ if Rails.env.development? || Rails.env.test?
end

task :validate do
sh "rbs", "-Isig", "validate", "--silent"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --silent option was deprecated since RBS-3.4.0 silently (refs: ruby/rbs@bc5dc67)

Copy link
Contributor

@unasuke unasuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@unasuke unasuke merged commit 5dad899 into kaigionrails:main Jan 25, 2024
2 checks passed
@tk0miya tk0miya deleted the update_rbs_collection branch January 26, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants