Type check jobs #97
Merged
Type check jobs #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
commented
Nov 3, 2023
| @@ -26,6 +26,7 @@ def github_jwt | |||
| exp: Time.now.to_i + (10 * 60), | |||
| iss: ENV["GITHUB_APP_ID"], | |||
| } | |||
| JWT.encode(payload, OpenSSL::PKey::RSA.new(ENV["GITHUB_PRIVATE_KEY"].unpack1("m*"), ''), "RS256") | |||
| pem = ENV.fetch("GITHUB_PRIVATE_KEY").unpack1("m*") #: String | |||
There was a problem hiding this comment.
I changed Hash#[] to Hash#fetch because the former one returns String?. Additionally, I added the type comment to indicate the return value of String#unpack is ambigous.
tk0miya
commented
Nov 3, 2023
| @@ -0,0 +1,3 @@ | |||
| class ApplicationJob < ActiveJob::Base | |||
| include _RbsRailsPathHelpers | |||
There was a problem hiding this comment.
I added this include statement to use path helper methods in the Job subclasses.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This contains #96