Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rgdal dependencies #114

Closed
kaijagahm opened this issue Jun 20, 2023 · 2 comments · Fixed by #117
Closed

Fix rgdal dependencies #114

kaijagahm opened this issue Jun 20, 2023 · 2 comments · Fixed by #117
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kaijagahm
Copy link
Owner

When I load the package, I get the following message as of recently:

The legacy packages maptools, rgdal, and rgeos, underpinning this package
will retire shortly. Please refer to R-spatial evolution reports on
https://r-spatial.org/r/2023/05/15/evolution4.html for details.
This package is now running under evolution status 0

We need to update vultureUtils so it doesn't depend on these packages anymore, but without changing the outputs.

This is because rgdal is retiring. Apparently I'm actually an entire year late to dealing with this. Ugh.
Resources for dealing with this:

The places where I know this package uses rgdal/maptools/rgeos are 1) the "distgeo" function crops up in various places for distance calculations, I think, and 2) some of the sunrise/sunset calculations use maptools functions, and I don't want them to.

@kaijagahm kaijagahm added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 20, 2023
@ryannguyen6392
Copy link
Collaborator

I think maptools is only used once in get_roosts_df and is addressed here in the corresponding PR.

distGeo is used by geosphere, which in turn ports sp. However, sp seems to be handling the issue. The other direct ports are move and spatsoc. Though move also ports sp and spatsoc seems to be handling the issue, see ropensci/spatsoc#50

@robitalec
Copy link

You might be interested in move2, which uses sf instead of sp
https://gitlab.com/bartk/move2

spatsoc should be updated soon, and will use sf instead of sp.
The grouping functions won't noticeably change, but the returned objects from build_lines and build_polys will be sf objects. Hopefully that doesn't disrupt users too much if they are using those functions and expecting sp objects returned.

Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants