Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalisations and transforms for int16 image types #457

Merged
merged 19 commits into from
May 22, 2024
Merged

Normalisations and transforms for int16 image types #457

merged 19 commits into from
May 22, 2024

Conversation

ioangatop
Copy link
Collaborator

Closes #451

ioangatop and others added 17 commits April 29, 2024 15:28
@ioangatop
Change total segmentators output binary one-hot masks to a semantic m…
552952e 
…ask (#390)
@ioangatop
Add support for 8bit images in TotalSegmentator (#398)
2cb935a
@ioangatop
Add read_nifti_slice to optionally cast image to stored input type (#…
f3a3a40 
…392)
@ioangatop
Update CI triggering events (#406)
db04a5c
@ioangatop
Move model freezing functionality to configure_model (#409)
7985745
@nkaenzig
Updated developer guide (#418)
dda22c3
@ioangatop
Update TotalSegmentator2D dataset to fetch all the slices (#416)
2997748
@ioangatop
merge with 402
de954ed
@ioangatop
update
312ab3d
@ioangatop
improve docs
1e3066c
@ioangatop
change default to uint8
37f0e0c
@ioangatop
Move metrics to CPU when using single device (#446)
706b6f5
@ioangatop
Merge branch '442-allow-to-train-with-int16-data' into 451-clip-int16…
77f466f 
…-values-of-ct-scans
@ioangatop
merge with 402
d03565f
@ioangatop
updates
dbe1d37
@ioangatop
updates
3087f31
@ioangatop
fix norm transform
07ca87d
@ioangatop ioangatop added vision Changes regarding the vision part of the library aggregated-feature labels May 17, 2024
@ioangatop ioangatop self-assigned this May 17, 2024
@ioangatop ioangatop marked this pull request as ready for review May 17, 2024 12:39
nkaenzig
nkaenzig reviewed May 22, 2024
View reviewed changes
Copy link
Collaborator

@nkaenzig nkaenzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Should we add some unit tests for the transforms and the functional modules?

@ioangatop
Copy link
Collaborator Author

Looks very good! Should we add some unit tests for the transforms and the functional modules?

Tests added 🙌

nkaenzig
nkaenzig approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@nkaenzig nkaenzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ioangatop ioangatop merged commit 35bb532 into 402-aggregated-feature-segmentation-downstream-evaluation-tasks May 22, 2024
5 checks passed
@ioangatop ioangatop deleted the 451-clip-int16-values-of-ct-scans branch May 22, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkaenzig nkaenzig nkaenzig approved these changes

@roman807 roman807 Awaiting requested review from roman807

Assignees

@ioangatop ioangatop

Labels
aggregated-feature vision Changes regarding the vision part of the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ioangatop @roman807 @nkaenzig