Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PatchCamelyon dataset #79

Merged
merged 24 commits into from
Feb 1, 2024
Merged

Add PatchCamelyon dataset #79

merged 24 commits into from
Feb 1, 2024

Conversation

ioangatop
Copy link
Collaborator

@ioangatop ioangatop commented Jan 30, 2024 •
edited

Close #72

Adds:

  • PCam dataset class
  • PCam documentation
  • PCam unit tests
  • Git LFS support for test assets
  • Common file_io ops in utils

@ioangatop ioangatop added vision Changes regarding the vision part of the library datasets labels Jan 30, 2024
@ioangatop ioangatop self-assigned this Jan 30, 2024
@ioangatop ioangatop linked an issue Jan 30, 2024 that may be closed by this pull request
Add PatchCamelyon dataset #72
Closed
@ioangatop ioangatop marked this pull request as ready for review January 30, 2024 11:31
@ioangatop ioangatop mentioned this pull request Jan 30, 2024
Closed
@roman807
Copy link
Collaborator

Looks good!

One comment re naming: In general i'd prefer longer & explicit names over abbreviations --> would use patch_camelyon instead of pcam everywhere (also is consistent with class-name PatchCamelyon)

@ioangatop
Copy link
Collaborator Author

Looks good!

One comment re naming: In general i'd prefer longer & explicit names over abbreviations --> would use patch_camelyon instead of pcam everywhere (also is consistent with class-name PatchCamelyon)

Good point, done; I renamed all pcam to patch_camelyon with b918cda

@nkaenzig nkaenzig mentioned this pull request Jan 30, 2024
Merged
nkaenzig
nkaenzig reviewed Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@nkaenzig nkaenzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I left some comments.

tests/eva/vision/data/datasets/test_patch_camelyon.py Show resolved Hide resolved
src/eva/utils/file_io.py Outdated Show resolved Hide resolved
assets/datasets/patch_camelyon/download.sh Outdated Show resolved Hide resolved
src/eva/vision/data/datasets/patch_camelyon.py Show resolved Hide resolved
src/eva/vision/data/datasets/patch_camelyon.py Show resolved Hide resolved
@nkaenzig nkaenzig mentioned this pull request Jan 30, 2024
Closed
@nkaenzig nkaenzig mentioned this pull request Feb 1, 2024
Merged
nkaenzig
nkaenzig approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@nkaenzig nkaenzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice! I think it's ready to go.

@ioangatop ioangatop merged commit 334ff7b into main Feb 1, 2024
2 checks passed
@ioangatop ioangatop deleted the 72-add-patchcamelyon-dataset branch February 1, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman807 roman807 roman807 left review comments

@nkaenzig nkaenzig nkaenzig approved these changes

Assignees

@ioangatop ioangatop

Labels
vision Changes regarding the vision part of the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PatchCamelyon dataset
3 participants
@ioangatop @roman807 @nkaenzig