Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'ismobilejs' import is an empty object #94

Closed
b12k opened this issue Aug 15, 2019 · 3 comments · Fixed by #95
Closed

'ismobilejs' import is an empty object #94

b12k opened this issue Aug 15, 2019 · 3 comments · Fixed by #95
Labels

Comments

@b12k
Copy link

b12k commented Aug 15, 2019

Hello,
After upgrading ismobilejs version from v0.5.2, which is present on NPM but not in github releases btw, to v1.0.1 the result of webpacks import function is {}.
Executed in mounted hook of js framework, used in browser, built with webpack.

  const { default: isMobile } = await import('ismobilejs');
  console.log(isMobile); //> {}

Thank you in advance!

@sectsect
Copy link

I have same problem.

import isMobile from 'ismobilejs';

export default () => {
  console.log(isMobile);
  // {}
};

@kaimallea
Copy link
Owner

Yikes, sorry about the breakage! Fix incoming

kaimallea added a commit that referenced this issue Aug 19, 2019
use of browser property in package.json was causing webpack break

fix #94
@kaimallea
Copy link
Owner

🎉 This issue has been resolved in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants