-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added iOS Universal User Agent. #116
Conversation
added support for ios universal user agent tag, which is used, for example, in inappbrowsers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
What needs to be done with this one to move on, please? "Merging can be performed automatically with 1 approving review." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump :)
universal: match(appleUniversal), | ||
device: | ||
(match(appleIphone) || match(appleIpod) || match(appleTablet)) && | ||
!match(windowsPhone), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apple.device should include universal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, should be added to device
@@ -129,6 +132,7 @@ export default function isMobile(userAgent?: string): isMobileResult { | |||
}; | |||
|
|||
result.any = | |||
result.apple.universal || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed when apple.universal is included in apple.device
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I'll merge and then apply @OlympicLarry 's suggestions that I agree with |
🎉 This PR is included in version 1.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I've added support for iOS Universal User Agent tag, so please review and let me know - or just add it, please. :)