Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some err to warnings #124

Merged
merged 1 commit into from
May 8, 2023
Merged

Move some err to warnings #124

merged 1 commit into from
May 8, 2023

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented May 8, 2023

As they are not critical, we can advise over them to pinpoint to a wrong config, but they are not critical and we dont expect them to work to have a working system

Fixes: kairos-io/kairos#1367

As they are not critical, we can advise over them to pinpoint to a wrong
config, but they are not critical and we dont expect them to work to
have a working system

Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
@Itxaka Itxaka requested a review from a team May 8, 2023 12:56
@Itxaka Itxaka enabled auto-merge (squash) May 8, 2023 12:56
@codecov-commenter
Copy link

Codecov Report

Merging #124 (84ceb0d) into master (14426d3) will not change coverage.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   18.02%   18.02%           
=======================================
  Files          15       15           
  Lines        1559     1559           
=======================================
  Hits          281      281           
  Misses       1254     1254           
  Partials       24       24           
Impacted Files Coverage Δ
pkg/mount/dag_steps.go 3.99% <0.00%> (ø)
pkg/mount/operation.go 37.50% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Itxaka Itxaka merged commit 9399d0c into master May 8, 2023
3 checks passed
@jimmykarily jimmykarily deleted the erro_to_warn branch May 9, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ errors on boot of a derivative after upgrade from kairos 1.5 .to 2.0.3
3 participants