Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "standard" flavor os-release variables optional #62

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

jimmykarily
Copy link
Contributor

@jimmykarily jimmykarily commented Dec 14, 2023

and change ARCH to TARGETARCH to simplify how it's passed down from Earthly in the kairos repo

Part of: kairos-io/kairos#1999

and change ARCH to TARGETARCH to simplify how it's passed down from
Earthly in the kairos repo

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily jimmykarily marked this pull request as ready for review December 14, 2023 14:52
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (a8707c1) 52.14% compared to head (bdd11bc) 52.06%.

Files Patch % Lines
versioneer/cli.go 0.00% 9 Missing ⚠️
versioneer/versioneer.go 25.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   52.14%   52.06%   -0.09%     
==========================================
  Files          16       16              
  Lines        1377     1383       +6     
==========================================
+ Hits          718      720       +2     
- Misses        563      567       +4     
  Partials       96       96              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimmykarily jimmykarily merged commit 74a57eb into main Dec 14, 2023
2 of 4 checks passed
@jimmykarily jimmykarily deleted the 1999-make-standard-variables-optional branch December 14, 2023 14:57
jimmykarily added a commit to kairos-io/kairos-agent that referenced this pull request Dec 14, 2023
kairos-io/kairos-sdk#62

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants