Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce a stage after node has joined the p2p cluster #2518

Closed
6ixfalls opened this issue Apr 26, 2024 · 4 comments · Fixed by kairos-io/kairos-docs#194
Closed

feat: Introduce a stage after node has joined the p2p cluster #2518

6ixfalls opened this issue Apr 26, 2024 · 4 comments · Fixed by kairos-io/kairos-docs#194
Assignees
Labels
chore documentation Improvements or additions to documentation

Comments

@6ixfalls
Copy link

Is your feature request related to a problem? Please describe.

Currently its difficult to apply manifests after the k3s server has started while in p2p mode. When I use k3s blocks, I'm able to do this during the boot stage, but with p2p enabled, there's no stage that runs after p2p has negotiated the cluster roles. As a result, I'm forced to use reconcile for this, but that's not a reliable solution because if the cluster takes more than 5 minutes to bootstrap, it takes an additional 60 minutes before my manifests and scripts are run and therefore leads to a poor user experience.

Describe the solution you'd like

There should be another kairos agent stage, something like cluster-ready, which is called when the current node has received a p2p role and after the k3s server or agent is started.

Describe alternatives you've considered

I've tried the reconcile stage but it will take 65 minutes after first boot before the cluster is ready.

@6ixfalls 6ixfalls added enhancement New feature or request triage Add this label to issues that should be triaged and prioretized in the next planning call labels Apr 26, 2024
@ci-robbot ci-robbot added the question Further information is requested label Apr 26, 2024
@ci-robbot
Copy link
Collaborator

Hello,

This is a bot, an experiment of @mudler and @jimmykarily. Thank you for opening the issue #2518 in the repository kairos-io/kairos.

Your issue seems to meet most of the project's requirements. There's a clear description of the problem and the desired solution. You have also provided an alternative solution considered.

However, it would be helpful if you could specify which versions of the relevant artifacts you are using. This information can help the maintainers better understand and address the issue.

Current labels: [triage]

@jimmykarily jimmykarily removed the triage Add this label to issues that should be triaged and prioretized in the next planning call label Apr 29, 2024
@jimmykarily
Copy link
Contributor

The provider-kairos already runs some stages. There is no reason why we couldn't introduce another one.

@mudler
Copy link
Member

mudler commented Apr 29, 2024

The provider-kairos already runs some stages. There is no reason why we couldn't introduce another one.

indeed, I think it's just about documentation, there are already two stages being fired from the provider:

@6ixfalls are those enough for your use case? it is more complex to determine when the cluster is ready after all nodes have joined the p2p network - which likely would require a larger work.

@6ixfalls
Copy link
Author

That is actually exactly what I'm looking for - definitely documentation is important because I had no idea those existed 😅

@mudler mudler added documentation Improvements or additions to documentation chore and removed enhancement New feature or request question Further information is requested labels May 6, 2024
@mauromorales mauromorales self-assigned this May 10, 2024
mauromorales added a commit to kairos-io/kairos-docs that referenced this issue May 10, 2024
Fixes kairos-io/kairos#2518

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants